Skip to content

Conversation

@Gustrb
Copy link
Contributor

@Gustrb Gustrb commented Feb 11, 2025

Proposed changes (including videos or screenshots)

Currently, there is no way to run an app when a given system message is sent, since we only trigger the IPostMessageSent for normal messages.
We could have followed the approach of having system messages also trigger the event, but that would create a pain point, since we would not be able to add the methods to check (to block messages).
This Pull Request, introduces the new event that is triggered on system messages, so the apps can respond to it

Issue(s)

Steps to test or reproduce

Further comments

CONN-482

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 11, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2025

🦋 Changeset detected

Latest commit: bd3d4a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/apps-engine Minor
@rocket.chat/apps Minor
@rocket.chat/core-services Patch
@rocket.chat/core-typings Minor
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/rest-typings Minor
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Gustrb Gustrb added this to the 7.4.0 milestone Feb 11, 2025
@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.44%. Comparing base (b9e7e38) to head (bd3d4a3).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35177   +/-   ##
========================================
  Coverage    59.44%   59.44%           
========================================
  Files         2827     2827           
  Lines        68163    68163           
  Branches     15123    15123           
========================================
  Hits         40517    40517           
  Misses       24990    24990           
  Partials      2656     2656           
Flag Coverage Δ
unit 75.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert changed the title feat: add IPostSystemMessageSent event feat(apps): add IPostSystemMessageSent event Feb 12, 2025
@Gustrb Gustrb marked this pull request as ready for review February 12, 2025 16:34
@Gustrb Gustrb requested review from a team as code owners February 12, 2025 16:34
@Gustrb Gustrb requested a review from d-gubert February 12, 2025 16:34
@Gustrb Gustrb added the stat: QA assured Means it has been tested and approved by a company insider label Feb 14, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 14, 2025
@kodiakhq kodiakhq bot merged commit 2921a6a into develop Feb 17, 2025
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the feat/post-sent-system-messages-event branch February 17, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants