-
Notifications
You must be signed in to change notification settings - Fork 13k
feat(apps): add IPostSystemMessageSent event #35177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: bd3d4a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35177 +/- ##
========================================
Coverage 59.44% 59.44%
========================================
Files 2827 2827
Lines 68163 68163
Branches 15123 15123
========================================
Hits 40517 40517
Misses 24990 24990
Partials 2656 2656
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: Marcos Spessatto Defendi <[email protected]>
Proposed changes (including videos or screenshots)
Currently, there is no way to run an app when a given system message is sent, since we only trigger the IPostMessageSent for normal messages.
We could have followed the approach of having system messages also trigger the event, but that would create a pain point, since we would not be able to add the methods to check (to block messages).
This Pull Request, introduces the new event that is triggered on system messages, so the apps can respond to it
Issue(s)
Steps to test or reproduce
Further comments
CONN-482