-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: updating some apps via Marketplace ignores permissions #35170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 2eb5bd5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35170 +/- ##
========================================
Coverage 59.43% 59.43%
========================================
Files 2825 2825
Lines 68155 68155
Branches 15123 15123
========================================
Hits 40505 40505
Misses 24992 24992
Partials 2658 2658
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
When an app that requests custom permissions would be updated via the Marketplace, the endpoint handler would not assign a valid value to the
permissionsGrantedfield sent to the apps-engine as a parameter. This would cause the checksum to be calculated without taking into account any permissions, but when validating the installation, thepermissionsGrantedfield would still contain data - this would cause the app to be marked asinvalid_installation_disabled.Issue(s)
CONN-387
Steps to test or reproduce
Further comments