-
Notifications
You must be signed in to change notification settings - Fork 13k
regression: desambiguate manually app routes #35145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35145 +/- ##
========================================
Coverage 59.22% 59.22%
========================================
Files 2824 2824
Lines 67980 67980
Branches 15117 15117
========================================
Hits 40259 40259
Misses 24892 24892
Partials 2829 2829
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
Since #34999 we removed the restivus router, that would do a bit of work to match the routes based on a tree (match on leafs). Now, since that was replaced by express, which uses a dumber route matcher algorithm, we must do the desambiguation of routes manually.
Example
Let's say we have a route apps/:id
And later we define a route apps/data
If the one fetches apps/data, the router will match as if the user desired to go to apps/:id with the id being "data"
Issue(s)
Steps to test or reproduce
Further comments
CONN-511