Skip to content

Conversation

@Gustrb
Copy link
Contributor

@Gustrb Gustrb commented Feb 6, 2025

Proposed changes (including videos or screenshots)

Since #34999 we removed the restivus router, that would do a bit of work to match the routes based on a tree (match on leafs). Now, since that was replaced by express, which uses a dumber route matcher algorithm, we must do the desambiguation of routes manually.

Example

Let's say we have a route apps/:id
And later we define a route apps/data

If the one fetches apps/data, the router will match as if the user desired to go to apps/:id with the id being "data"

Issue(s)

Steps to test or reproduce

Further comments

CONN-511

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 6, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: 01728b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Gustrb Gustrb changed the title fix: desambiguate manually the routes fix: desambiguate manually app routes Feb 6, 2025
@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.22%. Comparing base (fcbdcd1) to head (01728b3).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35145   +/-   ##
========================================
  Coverage    59.22%   59.22%           
========================================
  Files         2824     2824           
  Lines        67980    67980           
  Branches     15117    15117           
========================================
  Hits         40259    40259           
  Misses       24892    24892           
  Partials      2829     2829           
Flag Coverage Δ
unit 75.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Gustrb Gustrb marked this pull request as ready for review February 6, 2025 19:10
@Gustrb Gustrb changed the title fix: desambiguate manually app routes regression: desambiguate manually app routes Feb 6, 2025
@Gustrb Gustrb added this to the 7.4.0 milestone Feb 7, 2025
@Gustrb Gustrb added the stat: QA assured Means it has been tested and approved by a company insider label Feb 7, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 7, 2025
@Gustrb Gustrb requested a review from sampaiodiego February 7, 2025 12:51
@kodiakhq kodiakhq bot merged commit b190793 into develop Feb 7, 2025
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the fix/ambiguous-app-routes branch February 7, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants