fix: Notify user stream when enabling/disabling email2fa #35140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: ceca6df The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35140 +/- ##
========================================
Coverage 59.43% 59.43%
========================================
Files 2825 2825
Lines 68155 68155
Branches 15123 15123
========================================
Hits 40505 40505
Misses 24992 24992
Partials 2658 2658
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
suggested changes
Feb 7, 2025
Contributor
MarcosSpessatto
left a comment
MarcosSpessatto
left a comment
There was a problem hiding this comment.
What about adding a test to cover this?
MarcosSpessatto
approved these changes
Feb 12, 2025
dougfabris
approved these changes
Feb 12, 2025
Member
dougfabris
left a comment
dougfabris
left a comment
There was a problem hiding this comment.
Approving on behalf of frontend team
tiagoevanp
approved these changes
Feb 12, 2025
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
When a user enables/disables their email two factor, we were not sending this info on the streams, due to which the client side's
Meteor.user()wasn't reactive to this change.This PR propagates this change in user, making the client reactive to this change.
Issue(s)
The email 2FA buttons on user's security page are not reactive.
Steps to test or reproduce
Further comments
CORE-977