Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Feb 4, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CORE-968

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 4, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2025

🦋 Changeset detected

Latest commit: 8d3bf2e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.22%. Comparing base (c3c2725) to head (8d3bf2e).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35113   +/-   ##
========================================
  Coverage    59.22%   59.22%           
========================================
  Files         2824     2824           
  Lines        67979    67979           
  Branches     15116    15116           
========================================
  Hits         40259    40259           
  Misses       24891    24891           
  Partials      2829     2829           
Flag Coverage Δ
unit 75.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35113/

Built to branch gh-pages at 2025-02-05 18:40 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@dougfabris dougfabris changed the title chore: Includes attachments metadata into export messages JSON chore: Includes attachments metadata into JSON when exporting messages Feb 4, 2025
@dougfabris dougfabris marked this pull request as ready for review February 4, 2025 20:15
@dougfabris dougfabris requested a review from a team as a code owner February 4, 2025 20:15
@dougfabris dougfabris added this to the 7.4.0 milestone Feb 4, 2025
MarcosSpessatto
MarcosSpessatto previously approved these changes Feb 5, 2025
@dougfabris dougfabris changed the title chore: Includes attachments metadata into JSON when exporting messages feat: Includes attachments metadata into JSON when exporting messages Feb 5, 2025
@dougfabris dougfabris changed the title feat: Includes attachments metadata into JSON when exporting messages feat: Includes attachments metadata in JSON when exporting messages Feb 5, 2025
MarcosSpessatto
MarcosSpessatto previously approved these changes Feb 6, 2025
@gabriellsh gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label Feb 7, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 7, 2025
@kodiakhq kodiakhq bot merged commit 03cac4f into develop Feb 8, 2025
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the chore/attachmentMetadata branch February 8, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants