Skip to content

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Jan 28, 2025

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-955

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 28, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2025

🦋 Changeset detected

Latest commit: 222c144

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35044/

Built to branch gh-pages at 2025-02-03 17:01 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@KevLehman KevLehman force-pushed the fix/department-removal-setting branch from 39cc6b6 to f0cbe3b Compare January 29, 2025 16:38
@codecov
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.21%. Comparing base (4a7f1a5) to head (222c144).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35044      +/-   ##
===========================================
- Coverage    59.22%   59.21%   -0.01%     
===========================================
  Files         2824     2824              
  Lines        68071    68010      -61     
  Branches     15153    15132      -21     
===========================================
- Hits         40315    40274      -41     
+ Misses       24924    24909      -15     
+ Partials      2832     2827       -5     
Flag Coverage Δ
unit 75.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review January 29, 2025 18:11
@KevLehman KevLehman requested review from a team as code owners January 29, 2025 18:11
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Feb 3, 2025
@KevLehman KevLehman added this to the 7.4.0 milestone Feb 3, 2025
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Feb 3, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Feb 3, 2025
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Feb 3, 2025
@kodiakhq kodiakhq bot merged commit 1152961 into develop Feb 3, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the fix/department-removal-setting branch February 3, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants