Skip to content

Conversation

@tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan tassoevan requested a review from a team as a code owner January 24, 2025 22:51
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 24, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.4.0, but it targets 7.3.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2025

⚠️ No Changeset found

Latest commit: 4b275e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan tassoevan added this to the 7.4.0 milestone Jan 24, 2025
@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.17%. Comparing base (492eba9) to head (4b275e1).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35034      +/-   ##
===========================================
- Coverage    59.17%   59.17%   -0.01%     
===========================================
  Files         2822     2822              
  Lines        68116    68112       -4     
  Branches     15144    15144              
===========================================
- Hits         40310    40307       -3     
+ Misses       24975    24974       -1     
  Partials      2831     2831              
Flag Coverage Δ
unit 75.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link
Contributor

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35034/

Built to branch gh-pages at 2025-01-24 22:55 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ggazzo ggazzo merged commit 003c92d into develop Jan 25, 2025
49 checks passed
@ggazzo ggazzo deleted the chore/room-provider-effect branch January 25, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants