fix: Validate duplicated omnichannel contact email and phone #35032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: feb337b The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35032 +/- ##
===========================================
- Coverage 59.46% 59.45% -0.01%
===========================================
Files 2829 2830 +1
Lines 68279 68236 -43
Branches 15118 15101 -17
===========================================
- Hits 40601 40573 -28
+ Misses 25025 25014 -11
+ Partials 2653 2649 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
suggested changes
Jan 29, 2025
Contributor
MarcosSpessatto
left a comment
MarcosSpessatto
left a comment
There was a problem hiding this comment.
Can we add a changeset and a PR description?
dougfabris
reviewed
Jan 29, 2025
Member
dougfabris
left a comment
dougfabris
left a comment
There was a problem hiding this comment.
we won't check for existed phone numbers?
tiagoevanp
changed the title
…omnichannel-email-contact-validation
…:RocketChat/Rocket.Chat into fix/omnichannel-email-contact-validation
tiagoevanp
force-pushed
the
fix/omnichannel-email-contact-validation
branch
from
c274d76 to
2d4d076
Compare
MarcosSpessatto
previously approved these changes
Jan 31, 2025
KevLehman
previously approved these changes
Jan 31, 2025
dougfabris
requested changes
Jan 31, 2025
tiagoevanp
dismissed stale reviews from KevLehman and MarcosSpessatto
via
1bf7187
dougfabris
changed the title
Member
|
|
MarcosSpessatto
previously approved these changes
Feb 17, 2025
tiagoevanp
dismissed stale reviews from MarcosSpessatto and dougfabris
via
e2681c9
MarcosSpessatto
approved these changes
Feb 19, 2025
KevLehman
approved these changes
Feb 19, 2025
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
MartinSchoeler
approved these changes
Feb 19, 2025
MartinSchoeler
added
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
KevLehman
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Validate if any omnichannel contact is already registered by the same email or phone number.
Issue(s)
Steps to test or reproduce
Further comments
CORE-884