feat: filter thread messages in room message query #35013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 0f34b64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35013 +/- ##
========================================
Coverage 59.17% 59.17%
========================================
Files 2822 2822
Lines 68069 68069
Branches 15136 15136
========================================
Hits 40283 40283
Misses 24956 24956
Partials 2830 2830
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
|
d-gubert
requested changes
Jan 28, 2025
Member
d-gubert
left a comment
d-gubert
left a comment
There was a problem hiding this comment.
To be honest my first reaction was to be against adding a new flag for this, but since that's how the core models expose the filter, then I'm ok with it 😛
A few things:
- I think it's best to keep the name of the parameter the model method uses,
showThreadMessages- it will be better for us maintining it to see a familiar name. - When adding parameters to functions, they cannot change the original default behavior of the function - that would be a breaking change. As such, the default value of the option to show thread messages MUST be
true, and the user has to opt out of showing thread messages.
d-gubert
reviewed
Jan 28, 2025
d-gubert
reviewed
Jan 28, 2025
d-gubert
approved these changes
Jan 28, 2025
Dnouv
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
threadMsgCountwould be shown on the main message of a thread, the id of this message can then be used to fetch all the threaded messages using thethreadread bridge.Issue(s)
Steps to test or reproduce
Further comments
RCAI4-5