-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: increase RSA key size in FederationKeys.ts
#35011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
federationKeys
federationKeysFederationKeys.ts
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35011 +/- ##
========================================
Coverage 59.17% 59.17%
========================================
Files 2822 2822
Lines 68118 68118
Branches 15145 15145
========================================
Hits 40312 40312
Misses 24975 24975
Partials 2831 2831
Flags with carried forward coverage won't be shown. Click here to find out more. |
Fix for https://github.com/RocketChat/Rocket.Chat/security/code-scanning/399
To fix the problem, we need to increase the RSA key size to at least 2048 bits. This change will ensure that the generated keys are secure and comply with modern cryptographic standards.
Specifically, we will update the line
new NodeRSA({ b: 512 })to use a key size of 2048 bits. This change will not affect the existing functionality of the code but will enhance the security of the generated keys.https://rocketchat.atlassian.net/browse/VLN-92