Skip to content

Conversation

@julio-rocketchat
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 22, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.4.0, but it targets 7.3.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: bbd823a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35007/

Built to branch gh-pages at 2025-01-24 15:19 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.17%. Comparing base (5c7f985) to head (bbd823a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35007      +/-   ##
===========================================
- Coverage    59.17%   59.17%   -0.01%     
===========================================
  Files         2822     2822              
  Lines        68117    68116       -1     
  Branches     15145    15144       -1     
===========================================
- Hits         40311    40310       -1     
  Misses       24975    24975              
  Partials      2831     2831              
Flag Coverage Δ
unit 75.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@julio-rocketchat julio-rocketchat requested review from a team as code owners January 23, 2025 02:36
@julio-rocketchat julio-rocketchat added this to the 7.4.0 milestone Jan 24, 2025
@julio-rocketchat julio-rocketchat added the stat: QA assured Means it has been tested and approved by a company insider label Jan 24, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 24, 2025
@julio-rocketchat julio-rocketchat added stat: QA assured Means it has been tested and approved by a company insider and removed stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Jan 24, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 24, 2025
@kodiakhq kodiakhq bot merged commit 274f322 into develop Jan 24, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the bump-dependencies-with-known-sec-issues branch January 24, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants