fix: voip call history doesn't always log the correct call information #35006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 846ee05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #35006 +/- ##
===========================================
+ Coverage 64.79% 64.80% +0.01%
===========================================
Files 3153 3304 +151
Lines 104884 107875 +2991
Branches 19990 20295 +305
===========================================
+ Hits 67959 69911 +1952
- Misses 34237 35147 +910
- Partials 2688 2817 +129
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
pierre-lehnen-rc
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
cardoso
previously approved these changes
Jun 17, 2025
pierre-lehnen-rc
force-pushed
the
fix/voip-log-parser
branch
from
ee72bde to
b7d0f1a
Compare
…ata to the profile of all legs
kodiakhq
bot
removed
the
stat: ready to merge
Contributor
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
cardoso
approved these changes
Jun 30, 2025
dougfabris
approved these changes
Jul 1, 2025
MarcosSpessatto
approved these changes
Jul 2, 2025
pierre-lehnen-rc
added
the
stat: ready to merge
sem22-dev
pushed a commit
to sem22-dev/Rocket.Chat
that referenced
this pull request
Jul 4, 2025
MartinSchoeler
pushed a commit
that referenced
this pull request
Jul 10, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Several problems with the data currently stored on the VoIP call history:
- It logs too many "empty" calls that didn't happen (Still unknown why freeswitch is sending the events that are causing those in the first place)- If the same freeswitch server is used elsewhere, it is logging all of its calls as if the rocket.chat workspace had been involved on them.- If the same freeswitch server is used in multiple workspaces, it will log every call in every workspace, each of them with their own users.VSTAB-36
Steps to test or reproduce
Further comments