Skip to content

Conversation

@julio-rocketchat
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 22, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.4.0, but it targets 7.3.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: aeced49

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.17%. Comparing base (82971e8) to head (aeced49).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35001   +/-   ##
========================================
  Coverage    59.17%   59.17%           
========================================
  Files         2822     2822           
  Lines        68124    68124           
  Branches     15149    15149           
========================================
  Hits         40314    40314           
  Misses       24978    24978           
  Partials      2832     2832           
Flag Coverage Δ
unit 75.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35001/

Built to branch gh-pages at 2025-01-22 16:12 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@julio-rocketchat julio-rocketchat requested a review from a team January 22, 2025 08:44
abhinavkrin
abhinavkrin previously approved these changes Jan 22, 2025
Copy link
Contributor

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we forgetting to commit the change on package.json? 🤔

@julio-rocketchat julio-rocketchat added this to the 7.4.0 milestone Jan 22, 2025
@julio-rocketchat julio-rocketchat added the stat: QA assured Means it has been tested and approved by a company insider label Jan 22, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 22, 2025
@kodiakhq kodiakhq bot merged commit c8c8eaa into develop Jan 22, 2025
54 checks passed
@kodiakhq kodiakhq bot deleted the bump-vite-dependency branch January 22, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants