fix: Allow pagination params on channels.list
#34988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34988 +/- ##
========================================
Coverage 59.17% 59.17%
========================================
Files 2822 2822
Lines 68118 68118
Branches 15145 15145
========================================
Hits 40312 40312
Misses 24975 24975
Partials 2831 2831
Flags with carried forward coverage won't be shown. Click here to find out more. |
🦋 Changeset detectedLatest commit: bf402c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lucas-a-pelegrino
approved these changes
Jan 21, 2025
tapiarafael
approved these changes
Jan 21, 2025
MarcosSpessatto
suggested changes
Jan 21, 2025
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
MarcosSpessatto
approved these changes
Jan 23, 2025
juliajforesti
pushed a commit
that referenced
this pull request
Jan 28, 2025
Member
|
/patch |
Contributor
|
Pull request #35222 added to Project: "Patch 7.3.2" |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The type was right, but the schema didn't include the properties, and since we had
additionalPropertiesas false, AJV rejected the paramsIssue(s)
https://rocketchat.atlassian.net/browse/SUP-730
Steps to test or reproduce
Further comments