feat: Make Omnichannel room opening transactional #34958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 6912ac2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34958 +/- ##
===========================================
- Coverage 59.17% 59.17% -0.01%
===========================================
Files 2822 2820 -2
Lines 68118 67693 -425
Branches 15145 15071 -74
===========================================
- Hits 40312 40060 -252
+ Misses 24975 24814 -161
+ Partials 2831 2819 -12
Flags with carried forward coverage won't be shown. Click here to find out more. |
abhinavkrin
previously approved these changes
Jan 17, 2025
pierre-lehnen-rc
requested changes
Jan 17, 2025
MarcosSpessatto
previously approved these changes
Jan 17, 2025
pierre-lehnen-rc
approved these changes
Jan 20, 2025
MartinSchoeler
approved these changes
Jan 20, 2025
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
juliajforesti
pushed a commit
that referenced
this pull request
Jan 28, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This aims to prevent orphan rooms caused by some actions timing out, or just the process timing out.
An orphan room could be a room with no inquiry, or, the incredible case (?), an inquiry without a room. This happens because there were some actions in between the room creation and the inquiry creation that could fail, leaving a room with no inquiry. There was the posibiity of the inquiry creation failing, which would leave the room orphaned as well.
Since now both are in a transaction, they should be always created altogether, making it safer and less error prone.
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-929
Steps to test or reproduce
Further comments