Skip to content

Conversation

@yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Jan 17, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

  • Try to make a voice call in a DM
  • Modal appears notifying about missing config
  • Different modal content for normal users and admins based on License of workspace.

Further comments

CORE-779

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 17, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2025

🦋 Changeset detected

Latest commit: 3372001

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-voip Major
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34957/

Built to branch gh-pages at 2025-01-20 20:14 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.50%. Comparing base (479a7a7) to head (3372001).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34957      +/-   ##
===========================================
+ Coverage    59.44%   59.50%   +0.05%     
===========================================
  Files         2827     2826       -1     
  Lines        68163    68076      -87     
  Branches     15123    15118       -5     
===========================================
- Hits         40517    40506      -11     
+ Misses       24990    24912      -78     
- Partials      2656     2658       +2     
Flag Coverage Δ
unit 75.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal yash-rajpal marked this pull request as ready for review January 17, 2025 14:15
@yash-rajpal yash-rajpal requested a review from a team as a code owner January 17, 2025 14:15
@yash-rajpal yash-rajpal added this to the 7.3.0 milestone Jan 17, 2025
abhinavkrin
abhinavkrin previously approved these changes Jan 17, 2025
MartinSchoeler
MartinSchoeler previously approved these changes Jan 20, 2025
@scuciatto scuciatto modified the milestones: 7.3.0, 7.4.0 Jan 20, 2025
MartinSchoeler
MartinSchoeler previously approved these changes Jan 20, 2025
MartinSchoeler
MartinSchoeler previously approved these changes Jan 22, 2025
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Feb 13, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 13, 2025
@kodiakhq kodiakhq bot merged commit 1854c9b into develop Feb 14, 2025
44 of 45 checks passed
@kodiakhq kodiakhq bot deleted the teams-voip-feature-modal branch February 14, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants