Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Video conference volume setting #34941

Draft
wants to merge 4 commits into
base: feat/videoconf-volume-control
Choose a base branch
from

Conversation

rique223
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jan 13, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: 040a782

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rique223 rique223 changed the title Test/video conf volume test: Video conference volume setting Jan 13, 2025
Copy link
Contributor

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34941/

Built to branch gh-pages at 2025-01-13 21:05 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.18%. Comparing base (2909c05) to head (51011e1).
Report is 1 commits behind head on feat/videoconf-volume-control.

Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                       @@
##           feat/videoconf-volume-control   #34941   +/-   ##
==============================================================
  Coverage                          59.18%   59.18%           
==============================================================
  Files                               2821     2821           
  Lines                              68137    68137           
  Branches                           15154    15154           
==============================================================
  Hits                               40324    40324           
  Misses                             24978    24978           
  Partials                            2835     2835           
Flag Coverage Δ
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants