-
Notifications
You must be signed in to change notification settings - Fork 13k
chore: Improve Transcript service call chain #34920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34920 +/- ##
===========================================
+ Coverage 59.17% 59.19% +0.01%
===========================================
Files 2821 2820 -1
Lines 68140 67734 -406
Branches 15155 15085 -70
===========================================
- Hits 40325 40092 -233
+ Misses 24981 24820 -161
+ Partials 2834 2822 -12
Flags with carried forward coverage won't be shown. Click here to find out more. |
apps/meteor/ee/app/livechat-enterprise/server/lib/requestPdfTranscript.ts
Outdated
Show resolved
Hide resolved
MartinSchoeler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Symbolic OC review :)
Proposed changes (including videos or screenshots)
Basically, previous call was
meteor=>transcript=>queue=>transcript. The first call from meteor to the transcript service could be omitted if we do the logic on meteor.With the new changes, meteor is the one that decides if we call transcript directly (on sync calls, for tests) or if we queue the item (for regular work).
Changes should work and improve a bit whether you use microservices or not.
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-920
Steps to test or reproduce
Further comments