-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: SAML login redirects to incorrect room when using an invite #34873
Conversation
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #34873 +/- ##
=========================================
Coverage 59.12% 59.13%
=========================================
Files 2819 2819
Lines 67867 67341 -526
Branches 15117 15006 -111
=========================================
- Hits 40129 39822 -307
+ Misses 24907 24710 -197
+ Partials 2831 2809 -22
Flags with carried forward coverage won't be shown. Click here to find out more. |
🦋 Changeset detectedLatest commit: b3f1dba The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
apps/meteor/app/meteor-accounts-saml/server/lib/generators/AuthorizeRequest.ts
Outdated
Show resolved
Hide resolved
Pull request #34959 added to Project: "Patch 7.2.1" |
/backport 7.1.1 |
Sorry, I couldn't do that backport because of conflicts. Could you please solve them? you can do so by running the following commands:
after that just run |
/backport 7.1.1 |
Pull request #34961 added to Project: "Patch 7.1.1" |
/backport 7.0.5 |
Sorry, I couldn't do that backport because of conflicts. Could you please solve them? you can do so by running the following commands:
after that just run |
/backport 7.0.5 |
Pull request #34962 added to Project: "Patch 7.0.5" |
/backport 7.1.2 |
Sorry, I couldn't do that backport because of conflicts. Could you please solve them? you can do so by running the following commands:
after that just run |
/backport 7.1.2 |
Pull request #34971 added to Project: "Patch 7.1.2" |
/backport 7.2.2 |
Sorry, I couldn't do that backport because of conflicts. Could you please solve them? you can do so by running the following commands:
after that just run |
/backport 7.2.2 |
Pull request #34973 added to Project: "Patch 7.2.2" |
Proposed changes (including videos or screenshots)
id
andredirectUrl
from SAML's globalServiceProvideOptions
(since they're actually meant to relate to each client/request);Issue(s)
Steps to test or reproduce
Further comments
SUP-719