Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "Status" column values in "Custom Status" page table not translated #34857

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

AyushKumar123456789
Copy link

@AyushKumar123456789 AyushKumar123456789 commented Dec 31, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Closes #34856
CORE-910

Steps to test or reproduce

Before :

Custom.user.status.presence.not.translated.mp4

After :

image

Further comments

@AyushKumar123456789 AyushKumar123456789 requested a review from a team as a code owner December 31, 2024 13:18
Copy link
Contributor

dionisio-bot bot commented Dec 31, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 31, 2024

🦋 Changeset detected

Latest commit: 317675f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gabriellsh gabriellsh changed the title fix: Retain selected language for presence status in User Status settings after saving. fix: "Status" column values in "Custom Status" page table not translated Dec 31, 2024
.changeset/seven-otters-worry.md Outdated Show resolved Hide resolved
tassoevan
tassoevan previously approved these changes Dec 31, 2024
@AyushKumar123456789
Copy link
Author

AyushKumar123456789 commented Dec 31, 2024

Sir, I'm not an expert in this, but are these errors during the merge happening with every PR, or could there be another issue causing them ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Administration WorkspaceUser Status: Presence Language Reverts to English Upon Saving in any language.
4 participants