fix: Thumbnails are not deleted on room deletion #34851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 9a8146a The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #34851 +/- ##
===========================================
- Coverage 59.35% 59.16% -0.20%
===========================================
Files 2819 2821 +2
Lines 67650 68045 +395
Branches 15022 15116 +94
===========================================
+ Hits 40157 40261 +104
- Misses 24678 24959 +281
- Partials 2815 2825 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
MarcosSpessatto
approved these changes
Dec 31, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
files(array) field from messages instead of deprecatedfilefield when checking all uploads related to a message that should be deleted with it.Issue(s)
Steps to test or reproduce
Upload an image in a room, then delete the whole room.
Expected behavior: all uploads related to the uploaded image should be deleted after the room is deleted. Check the
rocketchat_uploadscollection to make sure both documents related to the image have been deleted (the image itself and the thumbnail).Current behavior: the image itself is deleted, but RC keeps the thumbnail in the
rocketchat_uploadscollection and in the selected storage type.Further comments
SUP-715