Skip to content

refactor: remove Meteor.call for addAllUserToRoom method (server) #34486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 4 commits into from
Jan 20, 2025
Merged

refactor: remove Meteor.call for addAllUserToRoom method (server) #34486

kodiakhq merged 4 commits into from
Jan 20, 2025

Conversation

@MarcosSpessatto
Copy link
Contributor

@MarcosSpessatto MarcosSpessatto commented Dec 23, 2024

https://rocketchat.atlassian.net/browse/CORE-901

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@MarcosSpessatto MarcosSpessatto added this to the 7.3.0 milestone Dec 23, 2024
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 23, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.4.0, but it targets 7.3.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 31df690

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.19%. Comparing base (1fb9f86) to head (31df690).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34486   +/-   ##
========================================
  Coverage    59.19%   59.19%           
========================================
  Files         2822     2822           
  Lines        68159    68168    +9     
  Branches     15159    15159           
========================================
+ Hits         40344    40354   +10     
  Misses       24981    24981           
+ Partials      2834     2833    -1
Flag Coverage Δ
unit 75.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2024 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34486/

Built to branch gh-pages at 2025-01-20 14:24 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review January 17, 2025 11:45
@MarcosSpessatto MarcosSpessatto requested a review from a team as a code owner January 17, 2025 11:45
@scuciatto scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Jan 20, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 20, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jan 20, 2025
@scuciatto scuciatto added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Jan 20, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 20, 2025
@scuciatto scuciatto removed this from the 7.3.0 milestone Jan 20, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jan 20, 2025
@scuciatto scuciatto added this to the 7.4.0 milestone Jan 20, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 20, 2025
@kodiakhq kodiakhq bot merged commit d949016 into develop Jan 20, 2025
51 checks passed
@kodiakhq kodiakhq bot deleted the refactor/remove-addAllUserToRoom-method branch January 20, 2025 17:20
juliajforesti pushed a commit that referenced this pull request Jan 28, 2025
@juliajforesti
refactor: remove Meteor.call for addAllUserToRoom method (server) (#3…
3093dd8 
…4486)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardogarim ricardogarim ricardogarim approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@MarcosSpessatto @ricardogarim @scuciatto