Skip to content

Conversation

@lucas-a-pelegrino
Copy link
Contributor

@lucas-a-pelegrino lucas-a-pelegrino commented Dec 20, 2024

Proposed changes (including videos or screenshots)

This PR adds a new setting to consider or not automatic messages (bot messages) on response time metrics.

Issue(s)

CORE-668

Steps to test or reproduce

Further comments

@lucas-a-pelegrino lucas-a-pelegrino added this to the 7.3.0 milestone Dec 20, 2024
@lucas-a-pelegrino lucas-a-pelegrino self-assigned this Dec 20, 2024
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 20, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: 20e4ecd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/i18n Minor
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-voip Major
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34274/

Built to branch gh-pages at 2025-01-24 16:17 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@scuciatto scuciatto modified the milestones: 7.3.0, 7.4.0 Jan 20, 2025
@codecov
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.48%. Comparing base (16aabf2) to head (20e4ecd).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34274      +/-   ##
===========================================
+ Coverage    59.44%   59.48%   +0.04%     
===========================================
  Files         2827     2827              
  Lines        68162    67963     -199     
  Branches     15123    15090      -33     
===========================================
- Hits         40516    40426      -90     
+ Misses       24990    24887     -103     
+ Partials      2656     2650       -6     

@lucas-a-pelegrino lucas-a-pelegrino requested review from a team as code owners January 22, 2025 15:36
tapiarafael
tapiarafael previously approved these changes Jan 22, 2025
lucas-a-pelegrino and others added 2 commits January 23, 2025 14:51
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
@MarcosSpessatto MarcosSpessatto removed the request for review from matheusbsilva137 January 29, 2025 12:23
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Feb 17, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 17, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Feb 17, 2025
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Feb 18, 2025
@kodiakhq kodiakhq bot merged commit 599fd93 into develop Feb 18, 2025
45 of 46 checks passed
@kodiakhq kodiakhq bot deleted the CORE-668 branch February 18, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants