Skip to content

Conversation

@aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Dec 17, 2024

Proposed changes (including videos or screenshots)

This PR introduces a new endpoint rooms.hide responsible for hiding rooms without type-specific restrictions.

Issue(s)

Steps to test or reproduce

Further comments

ARCH-1340

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 17, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: 856ea60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/rest-typings Minor
@rocket.chat/models Minor
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/cron Patch
@rocket.chat/instance-status Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/network-broker Patch
@rocket.chat/livechat Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/core-typings Minor
@rocket.chat/apps Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.44%. Comparing base (1854c9b) to head (856ea60).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34208   +/-   ##
========================================
  Coverage    59.44%   59.44%           
========================================
  Files         2827     2827           
  Lines        68163    68163           
  Branches     15123    15123           
========================================
  Hits         40517    40517           
  Misses       24990    24990           
  Partials      2656     2656           
Flag Coverage Δ
unit 75.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34208/

Built to branch gh-pages at 2025-02-04 15:42 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@aleksandernsilva aleksandernsilva force-pushed the feat/rooms-close-endpoint branch from 9189509 to 86e48fa Compare February 4, 2025 15:27
@aleksandernsilva aleksandernsilva marked this pull request as ready for review February 4, 2025 15:28
@aleksandernsilva aleksandernsilva requested review from a team as code owners February 4, 2025 15:28
@aleksandernsilva aleksandernsilva marked this pull request as draft February 10, 2025 16:49
@aleksandernsilva aleksandernsilva changed the title feat: rooms.close endpoint feat: rooms.hide endpoint Feb 10, 2025
@aleksandernsilva aleksandernsilva marked this pull request as ready for review February 12, 2025 12:45
@aleksandernsilva aleksandernsilva marked this pull request as draft February 12, 2025 13:42
@aleksandernsilva aleksandernsilva marked this pull request as ready for review February 13, 2025 12:39
KevLehman
KevLehman previously approved these changes Feb 13, 2025
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Feb 14, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 14, 2025
@kodiakhq kodiakhq bot merged commit eba8e36 into develop Feb 14, 2025
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the feat/rooms-close-endpoint branch February 14, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants