Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved wording for voice call permissions #34169

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Dec 12, 2024

Proposed changes (including videos or screenshots)

Changes the wording for voice call permissions, improving consistency and clarity.

  • Manage Voip Extension -> Manage Voice Calls

    Permission to manage voice calls and assign extensions to users

  • View VoIP extension details -> View Voice Call Extensions

    Permission to view which user is calling and their extension info

  • View User VoIP extension -> Allow Voice Calls

    Permission to allow users to use the voice call feature

Issue(s)

Steps to test or reproduce

  • Access workspace
  • Go to Workspace > Permissions
  • Search for VoIP

Further comments

CONN-435

Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: 54b0351

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/i18n Patch
@rocket.chat/meteor Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-voip Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (75643e1) to head (54b0351).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34169   +/-   ##
========================================
  Coverage    75.79%   75.79%           
========================================
  Files          511      511           
  Lines        22132    22132           
  Branches      5394     5394           
========================================
  Hits         16775    16775           
  Misses        4709     4709           
  Partials       648      648           
Flag Coverage Δ
unit 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 12, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34169/
on branch gh-pages at 2024-12-12 23:29 UTC

Copy link
Contributor

dionisio-bot bot commented Dec 12, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@aleksandernsilva aleksandernsilva marked this pull request as ready for review December 13, 2024 17:30
@aleksandernsilva aleksandernsilva modified the milestone: 7.2.0 Dec 13, 2024
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Dec 13, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 13, 2024
@kodiakhq kodiakhq bot merged commit a129e3e into develop Dec 13, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the feat/reword-voip-permissions branch December 13, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants