fix: Thread unread not in unread group

[juliajforesti]

Proposed changes (including videos or screenshots)

There's an edge case where a room with thread unread is not being added to the unread group because alert is false.
This PR adds tunread to the condition of adding the room to unread list

Issue(s)

Steps to test or reproduce

Further comments

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 1a815ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/ui-voip	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.18%. Comparing base (142fc42) to head (1a815ae).
Report is 14 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #33963      +/-   ##
===========================================
- Coverage    75.19%   75.18%   -0.01%     
===========================================
  Files          495      495              
  Lines        21601    21600       -1     
  Branches      5362     5362              
===========================================
- Hits         16242    16241       -1     
  Misses        4717     4717              
  Partials       642      642              

Flag	Coverage Δ
unit	75.18% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33963/
on branch gh-pages at 2024-11-18 16:27 UTC

[mors1eska]

Could you please let me know if my request on the forum is similar to what you have addressed in your issue?
Thank you in advance for your response

https://forums.rocket.chat/t/cant-set-up-notifications/15714/10

[juliajforesti]

Could you please let me know if my request on the forum is similar to what you have addressed in your issue? Thank you in advance for your response

forums.rocket.chat/t/cant-set-up-notifications/15714/10

Hey @mors1eska! I replied to you on the forum :)