Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apps-engine runtime fixes #33929

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix: apps-engine runtime fixes #33929

merged 2 commits into from
Nov 11, 2024

Conversation

d-gubert
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Nov 10, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.10.7, but it targets 6.10.6

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 10, 2024

🦋 Changeset detected

Latest commit: ccc1d5b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/omnichannel-services Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/authorization-service Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/presence-service Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/instance-status Patch
@rocket.chat/account-service Patch
@rocket.chat/message-parser Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/core-services Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/core-typings Patch
@rocket.chat/peggy-loader Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/queue-worker Patch
@rocket.chat/presence Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/license Patch
@rocket.chat/gazzodown Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/livechat Patch
@rocket.chat/models Patch
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/meteor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.10.7@a837223). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-6.10.7   #33929   +/-   ##
=================================================
  Coverage                  ?   56.57%           
=================================================
  Files                     ?     2501           
  Lines                     ?    55671           
  Branches                  ?    11522           
=================================================
  Hits                      ?    31497           
  Misses                    ?    21480           
  Partials                  ?     2694           
Flag Coverage Δ
e2e 56.42% <ø> (?)
unit 71.24% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert marked this pull request as ready for review November 11, 2024 00:24
@d-gubert d-gubert requested review from a team as code owners November 11, 2024 00:24
@d-gubert d-gubert added this to the 6.10.7 milestone Nov 11, 2024
@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Nov 11, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 11, 2024
@ggazzo ggazzo merged commit 6fd8fd0 into release-6.10.7 Nov 11, 2024
50 checks passed
@ggazzo ggazzo deleted the fix/apps-engine-patch branch November 11, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants