chore: improve unread badge content a11y

[juliajforesti]

Proposed changes (including videos or screenshots)

• add aria-hidden to badge content to avoid SR to read content
• improve sidebar item and badge aria-label
• fix mark-unread flaky test

Issue(s)

Steps to test or reproduce

Further comments

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33903/
on branch gh-pages at 2024-11-12 18:58 UTC

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.42%. Comparing base (19f34c5) to head (13904b8).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #33903      +/-   ##
===========================================
- Coverage    59.42%   59.42%   -0.01%     
===========================================
  Files         2829     2829              
  Lines        68334    68333       -1     
  Branches     15133    15133              
===========================================
- Hits         40610    40609       -1     
  Misses       25066    25066              
  Partials      2658     2658              

Flag	Coverage Δ
unit	75.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 13904b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR