chore: prune the token whenever we receieve a 403 #33885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: f0edc99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33885 +/- ##
============================================
+ Coverage 59.17% 75.00% +15.82%
============================================
Files 2822 517 -2305
Lines 68069 22757 -45312
Branches 15136 5523 -9613
============================================
- Hits 40283 17069 -23214
+ Misses 24956 5025 -19931
+ Partials 2830 663 -2167
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
|
diegolmello
reviewed
Nov 18, 2024
KevLehman
reviewed
Dec 18, 2024
Gustrb
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
KevLehman
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Whenever we try to send a push notification to a stale token, we get the SENDER_ID_MISSMATCH, and we should prune it from our database so we don't keep trying to send to those tokens.
This happens when the user has to regenerate their credentials, which had to happen in order to migrate the legacy push notification provider to FCM.
Here the approach is similar to: thingsboard/thingsboard#10679
Related issue on that codebase: thingsboard/thingsboard#10602 (comment)
Issue(s)
Steps to test or reproduce
Further comments
CONN-376