Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Updated VoIP field labels from "Free Extension Numbers" to "Available extensions" #33880

Merged
merged 8 commits into from
Nov 7, 2024

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Nov 4, 2024

Proposed changes (including videos or screenshots)

This PR aims to improve the field label clarity when assigning extensions for both Team voice calls (VoIP) and Omnichannel voice channel (VoIP). Labels with Free Extension Numbers were updated to Available extensions.

Before

Screenshot 2024-11-04 at 14 42 13

After

Screenshot 2024-11-04 at 14 28 44

Issue(s)

CORE-781

Steps to test or reproduce

Omnichannel voice channel

  • Access workspace
  • Configure VoIP for Omnichannel in Admin > Settings > Omnichannel voice channel (VoIP)
  • Access extensions tab
  • Click "Associate Agent"
  • Field "Available extensions" should be visible

Team voice calls

  • Access workspace
  • Enable team voice calls in Admin > Settings > Team voice calls (VoIP)
  • Click Assign extension in Admin > Users
  • Field "Available extensions" should be visible

Copy link
Contributor

dionisio-bot bot commented Nov 4, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 4, 2024

🦋 Changeset detected

Latest commit: 21d1181

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/i18n Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-voip Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aleksandernsilva aleksandernsilva changed the title i18n: Updated voip field labels with "Free Extension Numbers" to "Available extensions" i18n: Updated VoIP field labels with "Free Extension Numbers" to "Available extensions" Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33880/
on branch gh-pages at 2024-11-07 16:55 UTC

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.20%. Comparing base (4d0ab19) to head (03f0a5d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33880   +/-   ##
========================================
  Coverage    75.20%   75.20%           
========================================
  Files          495      495           
  Lines        21595    21595           
  Branches      5362     5362           
========================================
  Hits         16240    16240           
  Misses        4713     4713           
  Partials       642      642           
Flag Coverage Δ
unit 75.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva changed the title i18n: Updated VoIP field labels with "Free Extension Numbers" to "Available extensions" i18n: Updated VoIP field labels from "Free Extension Numbers" to "Available extensions" Nov 4, 2024
@aleksandernsilva aleksandernsilva added this to the 7.1.0 milestone Nov 4, 2024
@aleksandernsilva aleksandernsilva marked this pull request as ready for review November 4, 2024 20:43
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner November 4, 2024 20:43
@tiagoevanp tiagoevanp added the stat: QA assured Means it has been tested and approved by a company insider label Nov 7, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 7, 2024
@kodiakhq kodiakhq bot merged commit 322bafd into develop Nov 7, 2024
54 checks passed
@kodiakhq kodiakhq bot deleted the feat/updated-extension-label branch November 7, 2024 19:50
KevLehman pushed a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants