-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate from
field from Email Bridge
#33713
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 2f27d19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33713 +/- ##
========================================
Coverage 75.01% 75.01%
========================================
Files 480 480
Lines 21000 21000
Branches 5329 5329
========================================
Hits 15754 15754
Misses 4619 4619
Partials 627 627
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noice
Co-authored-by: Douglas Gubert <[email protected]>
Proposed changes (including videos or screenshots)
Deprecates the
from
field from the apps.engine Email bridge to avoid misuse. Also, cloud workspaces require to have thefrom
the same as defined in the settings, so we will get the value defined in theFrom_Email
setting by default.Issue(s)
Steps to test or reproduce
Further comments