Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sci): Restrict livechat visitors to their source type scope #33569

Merged
merged 25 commits into from
Oct 18, 2024

Conversation

matheusbsilva137
Copy link
Member

@matheusbsilva137 matheusbsilva137 commented Oct 14, 2024

Proposed changes (including videos or screenshots)

  • Added source field to ILivechatVisitor type, which stores the channel (eg API, widget, SMS, email-inbox, app) that's been used by the visitor to send messages. Each visitor can now only be linked to a single source, and each user that has already been linked to a source can't be reused in another channel.

Issue(s)

Steps to test or reproduce

Further comments

SCI-88

Copy link
Contributor

dionisio-bot bot commented Oct 14, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: 158b633

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/apps Minor
@rocket.chat/core-typings Minor
@rocket.chat/model-typings Minor
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/rest-typings Minor
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 14, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33569/
on branch gh-pages at 2024-10-17 23:55 UTC

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.85%. Comparing base (8670b57) to head (158b633).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33569   +/-   ##
========================================
  Coverage    74.85%   74.85%           
========================================
  Files          470      470           
  Lines        20743    20743           
  Branches      5294     5294           
========================================
  Hits         15528    15528           
  Misses        4595     4595           
  Partials       620      620           
Flag Coverage Δ
unit 74.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 changed the title feat: Restrict livechat visitors to their source type scope feat(sci): Restrict livechat visitors to their source type scope Oct 15, 2024
@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review October 15, 2024 05:18
@matheusbsilva137 matheusbsilva137 requested review from a team as code owners October 15, 2024 05:18
@matheusbsilva137 matheusbsilva137 added this to the 7.0 milestone Oct 15, 2024
apps/meteor/server/models/raw/LivechatVisitors.ts Outdated Show resolved Hide resolved
apps/meteor/server/models/raw/LivechatVisitors.ts Outdated Show resolved Hide resolved
apps/meteor/server/models/raw/LivechatVisitors.ts Outdated Show resolved Hide resolved
apps/meteor/server/models/raw/LivechatVisitors.ts Outdated Show resolved Hide resolved
apps/meteor/server/models/raw/LivechatVisitors.ts Outdated Show resolved Hide resolved
@matheusbsilva137 matheusbsilva137 modified the milestones: 7.0, 6.14 Oct 16, 2024
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
@matheusbsilva137 matheusbsilva137 added the stat: QA assured Means it has been tested and approved by a company insider label Oct 17, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 17, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Oct 17, 2024
@matheusbsilva137 matheusbsilva137 added the stat: ready to merge PR tested and approved waiting for merge label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants