Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Private apps restrictions are not applied on license removal #33400

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

matheusbsilva137
Copy link
Contributor

@matheusbsilva137 matheusbsilva137 commented Sep 30, 2024

Proposed changes (including videos or screenshots)

  • Apply CE restriction regarding private apps on license removal, and not only on server restart.

Issue(s)

Steps to test or reproduce

Demo:

demo-downgrade-apps.webm

Further comments

PASLR-5

@matheusbsilva137 matheusbsilva137 added this to the 7.0 milestone Sep 30, 2024
Copy link
Contributor

dionisio-bot bot commented Sep 30, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 30, 2024

🦋 Changeset detected

Latest commit: 5969558

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matheusbsilva137 matheusbsilva137 changed the title feat: Apply CE restrictions related to private apps on license removal fix: Private apps restrictions are not applied on license removal Sep 30, 2024
Copy link
Contributor

github-actions bot commented Sep 30, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-01 04:06 UTC

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.32%. Comparing base (bf02ce5) to head (5969558).
Report is 4 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33400   +/-   ##
==============================================
  Coverage          75.32%   75.32%           
==============================================
  Files                383      383           
  Lines              19383    19383           
  Branches            4980     4980           
==============================================
  Hits               14601    14601           
  Misses              4212     4212           
  Partials             570      570           
Flag Coverage Δ
unit 75.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Oct 1, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 1, 2024
@tassoevan tassoevan merged commit 6c43d22 into release-7.0.0 Oct 1, 2024
53 checks passed
@tassoevan tassoevan deleted the feat/disable-apps-license-removal branch October 1, 2024 04:05
gabriellsh pushed a commit that referenced this pull request Oct 7, 2024
…3400)

* feat: Apply CE restrictions related to private apps on license removal

* Create changeset
ggazzo pushed a commit that referenced this pull request Oct 8, 2024
…3400)

* feat: Apply CE restrictions related to private apps on license removal

* Create changeset
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
…3400)

* feat: Apply CE restrictions related to private apps on license removal

* Create changeset
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
…3400)

* feat: Apply CE restrictions related to private apps on license removal

* Create changeset
abhinavkrin pushed a commit that referenced this pull request Oct 11, 2024
…3400)

* feat: Apply CE restrictions related to private apps on license removal

* Create changeset
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
…3400)

* feat: Apply CE restrictions related to private apps on license removal

* Create changeset
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
…3400)

* feat: Apply CE restrictions related to private apps on license removal

* Create changeset
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
…3400)

* feat: Apply CE restrictions related to private apps on license removal

* Create changeset
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
…3400)

* feat: Apply CE restrictions related to private apps on license removal

* Create changeset
ggazzo pushed a commit that referenced this pull request Oct 14, 2024
…3400)

* feat: Apply CE restrictions related to private apps on license removal

* Create changeset
MartinSchoeler pushed a commit that referenced this pull request Oct 14, 2024
…3400)

* feat: Apply CE restrictions related to private apps on license removal

* Create changeset
ggazzo pushed a commit that referenced this pull request Oct 15, 2024
…3400)

* feat: Apply CE restrictions related to private apps on license removal

* Create changeset
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
…3400)

* feat: Apply CE restrictions related to private apps on license removal

* Create changeset
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
…3400)

* feat: Apply CE restrictions related to private apps on license removal

* Create changeset
debdutdeb pushed a commit that referenced this pull request Oct 18, 2024
…3400)

* feat: Apply CE restrictions related to private apps on license removal

* Create changeset
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
…3400)

* feat: Apply CE restrictions related to private apps on license removal

* Create changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants