Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Update private apps cap on Community Edition #33399

Merged
merged 17 commits into from
Oct 2, 2024

Conversation

matheusbsilva137
Copy link
Contributor

@matheusbsilva137 matheusbsilva137 commented Sep 30, 2024

Proposed changes (including videos or screenshots)

  • Update private apps cap on CE from 3 to 0;
  • Add end-to-end tests for private apps upload on CE and EE.

Issue(s)

Steps to test or reproduce

Enabling new private apps should not be allowed on CE starting on 7.0. They can be installed, but their status should be "Disabled" by default, and enabling them should not be available to CE.
While on Premium workspaces (including the Starter plan), no behavior should be changed: new private apps can be installed and their status should be "Enabled" by default as long as they're under the plan's max private apps limitation.

Further comments

PASLR-2

@matheusbsilva137 matheusbsilva137 added this to the 7.0 milestone Sep 30, 2024
Copy link
Contributor

dionisio-bot bot commented Sep 30, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 30, 2024

⚠️ No Changeset found

Latest commit: 295b4f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 30, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-02 20:26 UTC

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.32%. Comparing base (1259b8f) to head (295b4f0).
Report is 2 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.0.0   #33399      +/-   ##
=================================================
- Coverage          75.66%   75.32%   -0.34%     
=================================================
  Files                430      383      -47     
  Lines              19904    19383     -521     
  Branches            5079     4980      -99     
=================================================
- Hits               15060    14601     -459     
+ Misses              4273     4212      -61     
+ Partials             571      570       -1     
Flag Coverage Δ
unit 75.32% <ø> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review September 30, 2024 05:35
@matheusbsilva137 matheusbsilva137 requested review from a team as code owners September 30, 2024 05:35
@lucas-a-pelegrino lucas-a-pelegrino dismissed their stale review September 30, 2024 19:29

Dismissing until tests are proper.

@tassoevan tassoevan force-pushed the feat/private-apps-ce-cap branch from d2480bf to 466be31 Compare October 1, 2024 01:50
@ggazzo ggazzo changed the title feat: Update private apps cap on Community Edition chore!: Update private apps cap on Community Edition Oct 1, 2024
@matheusbsilva137
Copy link
Contributor Author

The new UI tests in this PR will only pass after #33416 gets merged (fixing a UI issue)

@matheusbsilva137 matheusbsilva137 force-pushed the feat/private-apps-ce-cap branch from 8c9f352 to 295b4f0 Compare October 2, 2024 04:35
@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review October 2, 2024 04:36
@matheusbsilva137 matheusbsilva137 added the stat: QA assured Means it has been tested and approved by a company insider label Oct 2, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 2, 2024
@matheusbsilva137 matheusbsilva137 merged commit 09d45b8 into release-7.0.0 Oct 2, 2024
52 checks passed
@matheusbsilva137 matheusbsilva137 deleted the feat/private-apps-ce-cap branch October 2, 2024 20:25
ggazzo pushed a commit that referenced this pull request Oct 8, 2024
* chore!: update private apps cap on CE

---------

Co-authored-by: Tasso <[email protected]>
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
* chore!: update private apps cap on CE

---------

Co-authored-by: Tasso <[email protected]>
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
* chore!: update private apps cap on CE

---------

Co-authored-by: Tasso <[email protected]>
abhinavkrin pushed a commit that referenced this pull request Oct 11, 2024
* chore!: update private apps cap on CE

---------

Co-authored-by: Tasso <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
* chore!: update private apps cap on CE

---------

Co-authored-by: Tasso <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
* chore!: update private apps cap on CE

---------

Co-authored-by: Tasso <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
* chore!: update private apps cap on CE

---------

Co-authored-by: Tasso <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
* chore!: update private apps cap on CE

---------

Co-authored-by: Tasso <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 14, 2024
* chore!: update private apps cap on CE

---------

Co-authored-by: Tasso <[email protected]>
MartinSchoeler pushed a commit that referenced this pull request Oct 14, 2024
* chore!: update private apps cap on CE

---------

Co-authored-by: Tasso <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 15, 2024
* chore!: update private apps cap on CE

---------

Co-authored-by: Tasso <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
* chore!: update private apps cap on CE

---------

Co-authored-by: Tasso <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
* chore!: update private apps cap on CE

---------

Co-authored-by: Tasso <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
* chore!: update private apps cap on CE

---------

Co-authored-by: Tasso <[email protected]>
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
* chore!: update private apps cap on CE

---------

Co-authored-by: Tasso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants