-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: Update private apps cap on Community Edition #33399
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33399 +/- ##
=================================================
- Coverage 75.66% 75.32% -0.34%
=================================================
Files 430 383 -47
Lines 19904 19383 -521
Branches 5079 4980 -99
=================================================
- Hits 15060 14601 -459
+ Misses 4273 4212 -61
+ Partials 571 570 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Dismissing until tests are proper.
d2480bf
to
466be31
Compare
The new UI tests in this PR will only pass after #33416 gets merged (fixing a UI issue) |
8c9f352
to
295b4f0
Compare
* chore!: update private apps cap on CE --------- Co-authored-by: Tasso <[email protected]>
* chore!: update private apps cap on CE --------- Co-authored-by: Tasso <[email protected]>
* chore!: update private apps cap on CE --------- Co-authored-by: Tasso <[email protected]>
* chore!: update private apps cap on CE --------- Co-authored-by: Tasso <[email protected]>
* chore!: update private apps cap on CE --------- Co-authored-by: Tasso <[email protected]>
* chore!: update private apps cap on CE --------- Co-authored-by: Tasso <[email protected]>
* chore!: update private apps cap on CE --------- Co-authored-by: Tasso <[email protected]>
* chore!: update private apps cap on CE --------- Co-authored-by: Tasso <[email protected]>
* chore!: update private apps cap on CE --------- Co-authored-by: Tasso <[email protected]>
* chore!: update private apps cap on CE --------- Co-authored-by: Tasso <[email protected]>
* chore!: update private apps cap on CE --------- Co-authored-by: Tasso <[email protected]>
* chore!: update private apps cap on CE --------- Co-authored-by: Tasso <[email protected]>
* chore!: update private apps cap on CE --------- Co-authored-by: Tasso <[email protected]>
* chore!: update private apps cap on CE --------- Co-authored-by: Tasso <[email protected]>
* chore!: update private apps cap on CE --------- Co-authored-by: Tasso <[email protected]>
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Enabling new private apps should not be allowed on CE starting on 7.0. They can be installed, but their status should be "Disabled" by default, and enabling them should not be available to CE.
While on Premium workspaces (including the Starter plan), no behavior should be changed: new private apps can be installed and their status should be "Enabled" by default as long as they're under the plan's max private apps limitation.
Further comments
PASLR-2