Skip to content

feat: add-ons for apps #33392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

feat: add-ons for apps #33392

wants to merge 9 commits into from

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented Sep 27, 2024

Proposed changes (including videos or screenshots)

Apply add-on validation to apps that require add-ons.

  • Prevent apps that require an add-on from being enabled if the add-on is not available
  • When the license is invalidated, disable apps that require add-on - this should already happen based on previous rules, but it did not happen when a license was removed, only when it became invalid.
  • When the license is updated, validate changes to add-ons and update configuration accordingly

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Sep 27, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 27, 2024

⚠️ No Changeset found

Latest commit: a1e4669

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 27, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-04 12:52 UTC

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 59.37%. Comparing base (bc1e6ee) to head (af53e49).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33392      +/-   ##
===========================================
+ Coverage    58.35%   59.37%   +1.02%     
===========================================
  Files         2692     2557     -135     
  Lines        65265    63092    -2173     
  Branches     14730    14162     -568     
===========================================
- Hits         38084    37464     -620     
+ Misses       24403    22922    -1481     
+ Partials      2778     2706      -72     
Flag Coverage Δ
unit 75.30% <41.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert
Copy link
Member Author

d-gubert commented Oct 4, 2024

Closing in favor of #33433

@d-gubert d-gubert closed this Oct 4, 2024
@d-gubert d-gubert deleted the feat/apps-addons-phase-1 branch October 4, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant