fix: Async E2EE key exchange not working on develop #33378

KevLehman · 2024-09-26T18:16:21Z

Proposed changes (including videos or screenshots)

This was due to missing notifiers on development. As these notifiers are not used in production, we didn't have this problem yet.

Issue(s)

https://rocketchat.atlassian.net/browse/E2EE2-70

Steps to test or reproduce

Further comments

dionisio-bot · 2024-09-26T18:16:25Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2024-09-26T18:16:25Z

🦋 Changeset detected

Latest commit: d88d88c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-09-26T18:21:30Z

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-30 16:47 UTC

codecov · 2024-09-26T18:28:30Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.35%. Comparing base (bc1e6ee) to head (d88d88c).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #33378   +/-   ##
========================================
  Coverage    58.35%   58.35%           
========================================
  Files         2692     2692           
  Lines        65265    65265           
  Branches     14730    14730           
========================================
  Hits         38084    38084           
  Misses       24403    24403           
  Partials      2778     2778

Flag	Coverage Δ
unit	`75.32% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

…-dev

…ocket.Chat into feat/airgapped-restrictions * 'feat/airgapped-restrictions' of github.com:RocketChat/Rocket.Chat: (57 commits) fix: Async E2EE key exchange not working on develop (#33378) chore: Move Apps-Engine to monorepo (#32951) chore(Sidepanel): uses only local channels and discussions (#33387) chore: add gazzodown preview (#33279) fix: Avoid notifying `watch.settings` on uncaught errors (#33376) fix: race condition when forwarding livechat by splitting subscription removal (#33381) chore: Single Contact ID: improved typings and removed some duplicated code (#33324) ci: remove Jira-GitHub security integration (#33384) chore: add ui-composer to storybook (#33383) regression: `Sidepanel` sort requires refresh after room update (#33370) ci: use node20 for release action (#33343) Bump rocket.chat to 6.14.0-develop (#33366) chore: replace Meteor._localStorage -> Accounts.storageLocation (#33356) Release 6.13.0-rc.1 fix: Avoid destructuring `connectionData` when value is undefined (#33339) feat: Adds new admin feature preview setting management (#33212) regression: `Sidepanel` color highlight (#33342) chore: move common files to core-services (#33341) feat: Adds new admin feature preview setting management (#33212) chore: create network broker package (#33338) ...

This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.

ggazzo · 2024-10-01T00:51:34Z

this title 💩

if its only in develop, it should be a regression, and if only happens in develop its not a real problem ;)

KevLehman · 2024-10-01T02:33:05Z

Actually was on "development environments" because of Diego's changes not in prod yet lel

The changeset had the proper text, which is a win.

This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.

…ocket.Chat into airgapped/composer-restriction * 'feat/airgapped-restrictions' of github.com:RocketChat/Rocket.Chat: (27 commits) review fix: skip invalid test for now consolidate restriction logic inside module remove constant from restriction module fix changeset Move tests to test folder remove wrong import fix proxyquire for airGappedRestrictionsCheck.ts test fix fix: Async E2EE key exchange not working on develop (#33378) Fix airgappedRestrictionswrapper tests Fix airgappedRestrictionCheck tests undo fix AirGappedRestriction logic Update logic and tests chore: Move Apps-Engine to monorepo (#32951) chore(Sidepanel): uses only local channels and discussions (#33387) chore: add gazzodown preview (#33279) wip fix: Avoid notifying `watch.settings` on uncaught errors (#33376) ...

This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.

add missing notifiers to room changes

43d21c5

Create witty-apples-pretend.md

6b1b8dc

KevLehman modified the milestones: 6.12, 6.13 Sep 26, 2024

KevLehman marked this pull request as ready for review September 26, 2024 19:22

scuciatto modified the milestones: 6.13, 6.14 Sep 27, 2024

ricardogarim approved these changes Sep 27, 2024

View reviewed changes

KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Sep 30, 2024

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 30, 2024

Merge branch 'develop' into fix/async-e2e-key-exchange-not-working-on…

d88d88c

…-dev

kodiakhq bot merged commit 662aca3 into develop Sep 30, 2024
48 checks passed

kodiakhq bot deleted the fix/async-e2e-key-exchange-not-working-on-dev branch September 30, 2024 16:47

KevLehman added a commit that referenced this pull request Sep 30, 2024

fix: Async E2EE key exchange not working on develop (#33378)

0f1d256

KevLehman added a commit that referenced this pull request Sep 30, 2024

Revert "fix: Async E2EE key exchange not working on develop (#33378)"

0d7a6b3

This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.

KevLehman added a commit that referenced this pull request Oct 2, 2024

fix: Async E2EE key exchange not working on develop (#33378)

d1f41f1

KevLehman added a commit that referenced this pull request Oct 2, 2024

Revert "fix: Async E2EE key exchange not working on develop (#33378)"

ffb40a1

This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.

KevLehman added a commit that referenced this pull request Oct 3, 2024

fix: Async E2EE key exchange not working on develop (#33378)

b7bfeb6

KevLehman added a commit that referenced this pull request Oct 3, 2024

Revert "fix: Async E2EE key exchange not working on develop (#33378)"

1fdae8e

This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.

KevLehman added a commit that referenced this pull request Oct 8, 2024

fix: Async E2EE key exchange not working on develop (#33378)

817b72e

KevLehman added a commit that referenced this pull request Oct 8, 2024

Revert "fix: Async E2EE key exchange not working on develop (#33378)"

aa555b2

This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.

KevLehman added a commit that referenced this pull request Oct 8, 2024

Revert "fix: Async E2EE key exchange not working on develop (#33378)"

7147863

This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.

KevLehman added a commit that referenced this pull request Oct 9, 2024

Revert "fix: Async E2EE key exchange not working on develop (#33378)"

6295f59

This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.

KevLehman added a commit that referenced this pull request Oct 9, 2024

Revert "fix: Async E2EE key exchange not working on develop (#33378)"

cbc92be

This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.

KevLehman added a commit that referenced this pull request Oct 10, 2024

Revert "fix: Async E2EE key exchange not working on develop (#33378)"

4223655

This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.

KevLehman added a commit that referenced this pull request Oct 11, 2024

Revert "fix: Async E2EE key exchange not working on develop (#33378)"

6dd8edc

This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.

KevLehman added a commit that referenced this pull request Oct 11, 2024

Revert "fix: Async E2EE key exchange not working on develop (#33378)"

1e8de63

This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.

KevLehman added a commit that referenced this pull request Oct 11, 2024

Revert "fix: Async E2EE key exchange not working on develop (#33378)"

f02a28d

This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.

KevLehman added a commit that referenced this pull request Oct 11, 2024

Revert "fix: Async E2EE key exchange not working on develop (#33378)"

3ad86ff

This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.

KevLehman added a commit that referenced this pull request Oct 11, 2024

Revert "fix: Async E2EE key exchange not working on develop (#33378)"

4ab9843

This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.

KevLehman added a commit that referenced this pull request Oct 11, 2024

Revert "fix: Async E2EE key exchange not working on develop (#33378)"

3ed5831

This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.

KevLehman added a commit that referenced this pull request Oct 11, 2024

Revert "fix: Async E2EE key exchange not working on develop (#33378)"

57ac343

This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.

KevLehman added a commit that referenced this pull request Oct 14, 2024

Revert "fix: Async E2EE key exchange not working on develop (#33378)"

61dc75c

This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.

hugocostadev pushed a commit that referenced this pull request Oct 15, 2024

Revert "fix: Async E2EE key exchange not working on develop (#33378)"

c19737d

This reverts commit dcc98fbeb8ec2f4c09982aebb665382577394720.

ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024

This was referenced Oct 20, 2024

Release 7.0.0 #33677

Closed

Release 7.0.0 #33678

Closed

Release 7.0.0 #33679

Merged

abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024

fix: Async E2EE key exchange not working on develop (#33378)

8c8b773

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Async E2EE key exchange not working on develop #33378

fix: Async E2EE key exchange not working on develop #33378

KevLehman commented Sep 26, 2024 •

edited

Loading

dionisio-bot bot commented Sep 26, 2024 •

edited

Loading

changeset-bot bot commented Sep 26, 2024 •

edited

Loading

github-actions bot commented Sep 26, 2024 •

edited

Loading

codecov bot commented Sep 26, 2024 •

edited

Loading

ggazzo commented Oct 1, 2024

KevLehman commented Oct 1, 2024

fix: Async E2EE key exchange not working on develop #33378

fix: Async E2EE key exchange not working on develop #33378

Conversation

KevLehman commented Sep 26, 2024 • edited Loading

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

dionisio-bot bot commented Sep 26, 2024 • edited Loading

changeset-bot bot commented Sep 26, 2024 • edited Loading

🦋 Changeset detected

github-actions bot commented Sep 26, 2024 • edited Loading

codecov bot commented Sep 26, 2024 • edited Loading

Codecov Report

ggazzo commented Oct 1, 2024

KevLehman commented Oct 1, 2024

KevLehman commented Sep 26, 2024 •

edited

Loading

dionisio-bot bot commented Sep 26, 2024 •

edited

Loading

changeset-bot bot commented Sep 26, 2024 •

edited

Loading

github-actions bot commented Sep 26, 2024 •

edited

Loading

codecov bot commented Sep 26, 2024 •

edited

Loading