Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: publish preview github pages #33248

Merged
merged 1 commit into from
Sep 11, 2024
Merged

chore: publish preview github pages #33248

merged 1 commit into from
Sep 11, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Sep 10, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 10, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 247c19d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo force-pushed the chore/preview branch 3 times, most recently from a2b4305 to 468e87a Compare September 10, 2024 22:14
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 10, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-11 16:45 UTC

@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.73%. Comparing base (cbea8d4) to head (247c19d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33248   +/-   ##
========================================
  Coverage    59.73%   59.73%           
========================================
  Files         2548     2548           
  Lines        63073    63073           
  Branches     14090    14090           
========================================
  Hits         37679    37679           
  Misses       22978    22978           
  Partials      2416     2416
Flag Coverage Δ
unit 76.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the chore/preview branch 5 times, most recently from 4d5ecd3 to fc21216 Compare September 11, 2024 13:16
@ggazzo ggazzo changed the title chore: move playground to apps/ chore: publish preview github pages Sep 11, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Sep 11, 2024
@ggazzo ggazzo added this to the 6.13 milestone Sep 11, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 11, 2024
@ggazzo ggazzo marked this pull request as ready for review September 11, 2024 13:39
@ggazzo ggazzo requested a review from a team as a code owner September 11, 2024 13:39
@ggazzo ggazzo removed the stat: QA assured Means it has been tested and approved by a company insider label Sep 11, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 11, 2024
@sampaiodiego
Copy link
Member

we're missing an index with links to all packages with a preview

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Sep 11, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 11, 2024
@kodiakhq kodiakhq bot merged commit 9ef096f into develop Sep 11, 2024
52 checks passed
@kodiakhq kodiakhq bot deleted the chore/preview branch September 11, 2024 16:42
gabriellsh added a commit that referenced this pull request Sep 11, 2024
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fetc…
a6a7a58 
…hAvatarById

* 'develop' of github.com:RocketChat/Rocket.Chat:
  fix: Infinite loading when uploading a private app (#33181)
  chore: publish preview github pages (#33248)
  chore: move playground (#33260)
  chore: E2EE setting warning update (#33224)
  fix: message parser being slow to process very long messages with too many symbols (#33227)
  chore: fix ui-playground build (#33250)
  feat: Option to disable 2FA for OAuth users (#32945)
  fix: Allow to use the token from `room.v` when requesting transcript instead of finding visitor (#33211)
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
@ggazzo @abhinavkrin
chore: publish preview github pages (#33248)
d51b0ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
6.13
Development

Successfully merging this pull request may close these issues.
2 participants
@ggazzo @sampaiodiego