fix: Retention Policy cached settings not updated during upgrade procedure #33237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 5de9bff The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33237 +/- ##
===========================================
+ Coverage 59.33% 59.74% +0.40%
===========================================
Files 2548 2548
Lines 63363 63074 -289
Branches 14252 14092 -160
===========================================
+ Hits 37598 37681 +83
+ Misses 23062 22976 -86
+ Partials 2703 2417 -286
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
approved these changes
Sep 11, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
MarcosSpessatto
approved these changes
Sep 11, 2024
ggazzo
approved these changes
Sep 12, 2024
|
|
/patch |
|
Pull request #33265 added to Project: "Patch 6.12.1" |
|
/backport 6.11.3 |
|
Pull request #33266 added to Project: "Patch 6.11.3" |
|
/backport 6.10.6 |
|
Pull request #33267 added to Project: "Patch 6.10.6" |
Merged
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
During the server version upgrade procedure, internal DB events are not run before the migration procedures run. This means that other services initialized before that, that depend on updates from the DB are unaware of changes during this time.
In this specific case, the settings cached collection, which was being used to configure the retention policy cron, would have outdated data at the time of running the cron job. This caused issues in workspaces that had the Retention Policy enabled before upgrading to 6.10.
This issue was introduced here #32425
And this PR #33025 was aimed at fixing it, without success (the issue didn't trigger during testing with the fix, despite being tested by multiple people in different environments. Later a better process for reproducing it was found).
The fix for it was to force the cached settings to be updated manually during the migration procedure. An appropriate documentation will be written regarding directives when handling updates that affect sensitive services/features.
Issue(s)
CORE-681
Steps to test or reproduce
Further comments