fix: Multi-step modals closing unexpectedly #33158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 320a8dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33158 +/- ##
========================================
Coverage 59.33% 59.33%
========================================
Files 2547 2546 -1
Lines 63258 63247 -11
Branches 14221 14220 -1
========================================
- Hits 37531 37529 -2
+ Misses 23025 23016 -9
Partials 2702 2702
Flags with carried forward coverage won't be shown. Click here to find out more. |
dougfabris
force-pushed
the
fix/multistep-modal-closing
branch
2 times, most recently
from
9c825eb to
930bf9c
Compare
dougfabris
force-pushed
the
fix/multistep-modal-closing
branch
from
930bf9c to
f5134f5
Compare
ggazzo
approved these changes
Aug 27, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
|
/patch |
after that just run |
dougfabris
added a commit
that referenced
this pull request
Aug 28, 2024
|
/patch |
|
Pull request #33178 added to Project: "Patch 6.11.2" |
gabriellsh
added a commit
that referenced
this pull request
Sep 2, 2024
…ove/threadMetrics * 'develop' of github.com:RocketChat/Rocket.Chat: (49 commits) feat: add `sidepanelNavigation` to Feature preview list (#33156) refactor: Realtime Monitoring Counters to TS (#33182) fix: restore tooltips to units Multiselect (#33174) test: Add unit test for RoomMenu options (#32891) chore: remove notifyListener call that was causing startup issues (#33154) fix: Multi-step modals closing unexpectedly (#33158) Revert "refactor: Realtime Monitoring Counters to TS" (#33170) refactor: Realtime Monitoring Counters to TS (#33166) refactor: Uses `source` instead of `room` to render the `OmnichannelRoomIcon` (#33118) refactor: Realtime Monitoring Overviews to TS (#33167) test: Add e2e tests for teams multi-step modals (#33168) feat: add Advanced settings accordion to `EditRoomInfo` (#33114) chore: Revive Livechat Storybook (#33137) refactor: Realtime `Doughnout Charts` to TS (#33092) feat: create contact endpoint (#32693) chore: remove left streaming code (#33039) fix: show only relevant userInfoActions for mentioned non-members (#31525) feat: Setting for enabling files encryption and fix whitelist media types stopping E2EE uploads (#33003) refactor: Replace proxy functions from `LivechatTyped` class with direct calls (#33110) Revert "fix: Inconsistent Markdown Formatting in Custom Status Field" (#33127) ...
ggazzo
pushed a commit
that referenced
this pull request
Sep 3, 2024
Merged
Merged
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced here: #32482
Proposed changes (including videos or screenshots)
With the introduction of the
onClosecall in theuseEffectcleanup function inGenericModal, multi-step modals usingGenericModalstarted to close unexpectedly. This PR aims to remove the usage of theGenericModalin favor ofGenericModalSkeletonto solve this issue and keep the loading consistency.Issue(s)
Steps to test or reproduce
Further comments
CORE-660