-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: NPS passing startAt
as the expiration date when creating a banner
#33155
fix: NPS passing startAt
as the expiration date when creating a banner
#33155
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: e246c3b The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33155 +/- ##
===========================================
- Coverage 59.33% 59.32% -0.02%
===========================================
Files 2548 2548
Lines 63363 63415 +52
Branches 14252 14268 +16
===========================================
+ Hits 37598 37622 +24
- Misses 23062 23090 +28
Partials 2703 2703
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
Not much, dates were being swapped. Func was expecting the expiration date but NPS service was providing the start date from the NPS payload.
Issue(s)
https://rocketchat.atlassian.net/browse/SUP-649
Steps to test or reproduce
Further comments