fix: VideoConf message not considers display avatar pref #33141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 2c65dcc The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #33141 +/- ##
===========================================
- Coverage 59.22% 59.22% -0.01%
===========================================
Files 2824 2824
Lines 67979 68075 +96
Branches 15116 15151 +35
===========================================
+ Hits 40259 40315 +56
- Misses 24891 24927 +36
- Partials 2829 2833 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
dougfabris
force-pushed
the
fix/videoconf-display-avatars
branch
from
78fe4d9 to
3d5471f
Compare
dougfabris
force-pushed
the
fix/videoconf-display-avatars
branch
from
3d5471f to
7666449
Compare
Contributor
|
MarcosSpessatto
suggested changes
Jan 24, 2025
gabriellsh
requested changes
Jan 24, 2025
packages/ui-video-conf/src/VideoConfMessage/VideoConfMessageUserStack.tsx
Outdated
Show resolved
Hide resolved
packages/ui-video-conf/src/VideoConfMessage/VideoConfMessageUserStack.tsx
Outdated
Show resolved
Hide resolved
packages/fuselage-ui-kit/src/blocks/VideoConferenceBlock/VideoConferenceBlock.tsx
Outdated
Show resolved
Hide resolved
packages/fuselage-ui-kit/src/blocks/VideoConferenceBlock/VideoConferenceBlock.tsx
Outdated
Show resolved
Hide resolved
packages/fuselage-ui-kit/src/blocks/VideoConferenceBlock/VideoConferenceBlock.tsx
Outdated
Show resolved
Hide resolved
gabriellsh
previously approved these changes
Jan 27, 2025
dougfabris
force-pushed
the
fix/videoconf-display-avatars
branch
from
7b3eea9 to
3d328cd
Compare
gabriellsh
previously approved these changes
Jan 27, 2025
MarcosSpessatto
previously approved these changes
Jan 31, 2025
dougfabris
dismissed stale reviews from MarcosSpessatto and gabriellsh
via
a45297c
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
gabriellsh
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
CORE-656