Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Omnichannel's security and privacy settings page #32988

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Aug 5, 2024

Proposed changes (including videos or screenshots)

Depends on: #32987

Screenshot 2024-08-05 at 19 43 43

TODO:

  • Check which permissions will be necessary to access this page with product team

Issue(s)

Steps to test or reproduce

Further comments

SCI-32

Copy link
Contributor

dionisio-bot bot commented Aug 5, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 5, 2024

🦋 Changeset detected

Latest commit: a8be2cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris changed the title feat: Omnichannel's security and privacy settings pager feat: Omnichannel's security and privacy settings page Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.21%. Comparing base (56c685c) to head (a8be2cf).
Report is 1 commits behind head on feat/single-contact-id.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           feat/single-contact-id   #32988   +/-   ##
=======================================================
  Coverage                   58.21%   58.21%           
=======================================================
  Files                        2684     2684           
  Lines                       65114    65114           
  Branches                    14722    14722           
=======================================================
  Hits                        37909    37909           
  Misses                      24448    24448           
  Partials                     2757     2757           
Flag Coverage Δ
unit 76.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris force-pushed the feat/single-contact-id branch 3 times, most recently from 30e5f03 to a17f84c Compare August 8, 2024 13:22
@dougfabris dougfabris force-pushed the feat/oc-security-settings-page branch from e729b98 to 99c76e9 Compare August 8, 2024 20:09
@dougfabris dougfabris force-pushed the feat/single-contact-id branch 3 times, most recently from 2b90fb7 to 56c685c Compare August 20, 2024 14:42
@dougfabris dougfabris force-pushed the feat/oc-security-settings-page branch from 99c76e9 to 9aec060 Compare August 20, 2024 14:45
@dougfabris dougfabris marked this pull request as ready for review August 20, 2024 16:49
@dougfabris dougfabris requested a review from a team as a code owner August 20, 2024 16:49
@tassoevan tassoevan merged commit d667dee into feat/single-contact-id Aug 21, 2024
54 checks passed
@tassoevan tassoevan deleted the feat/oc-security-settings-page branch August 21, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants