-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Renders CodeMirrorBox
s full screen mode through portal
#32811
Conversation
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32811 +/- ##
===========================================
- Coverage 55.57% 55.50% -0.08%
===========================================
Files 2634 2634
Lines 57216 57215 -1
Branches 11850 11849 -1
===========================================
- Hits 31800 31755 -45
- Misses 22726 22766 +40
- Partials 2690 2694 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/backport 6.10.1 |
Pull request #32818 added to Project: "Patch 6.10.1" |
Proposed changes (including videos or screenshots)
After some attempts dealing with the
transform
prop after upgrading virtuoso we decided to rollback and remove it from theCustomScroller
on #32804.But removing this prop we bring back the initial problem #32625 regarding the
CodeMirrorBox
So the proposal solutions is render the
CodeMirrorBox
through a portal before removing the prop.Issue(s)
Steps to test or reproduce
Further comments