Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Renders CodeMirrorBoxs full screen mode through portal #32811

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jul 17, 2024

Proposed changes (including videos or screenshots)

After some attempts dealing with the transform prop after upgrading virtuoso we decided to rollback and remove it from the CustomScroller on #32804.

But removing this prop we bring back the initial problem #32625 regarding the CodeMirrorBox

So the proposal solutions is render the CodeMirrorBox through a portal before removing the prop.

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jul 17, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 17, 2024

⚠️ No Changeset found

Latest commit: 7915adb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.50%. Comparing base (3ffe4a2) to head (7915adb).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32811      +/-   ##
===========================================
- Coverage    55.57%   55.50%   -0.08%     
===========================================
  Files         2634     2634              
  Lines        57216    57215       -1     
  Branches     11850    11849       -1     
===========================================
- Hits         31800    31755      -45     
- Misses       22726    22766      +40     
- Partials      2690     2694       +4     
Flag Coverage Δ
e2e 54.23% <60.00%> (-0.13%) ⬇️
unit 72.08% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review July 17, 2024 13:46
@dougfabris dougfabris requested a review from a team as a code owner July 17, 2024 13:46
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabriellsh gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label Jul 17, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 17, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jul 17, 2024
@dougfabris dougfabris added the stat: ready to merge PR tested and approved waiting for merge label Jul 17, 2024
@kodiakhq kodiakhq bot merged commit 4ba8c04 into develop Jul 17, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the chore/code-mirror-portal branch July 17, 2024 17:08
@dougfabris
Copy link
Member Author

/backport 6.10.1

Copy link
Contributor

dionisio-bot bot commented Jul 17, 2024

Pull request #32818 added to Project: "Patch 6.10.1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants