Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New contact details tab #32725

Merged
merged 6 commits into from
Jul 10, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jul 4, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

SCI-12

Copy link
Contributor

dionisio-bot bot commented Jul 4, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 4, 2024

🦋 Changeset detected

Latest commit: 5cb16c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 56.19048% with 46 lines in your changes missing coverage. Please review.

Project coverage is 56.75%. Comparing base (9f7654f) to head (5cb16c4).

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feat/single-contact-id   #32725      +/-   ##
==========================================================
+ Coverage                   56.71%   56.75%   +0.04%     
==========================================================
  Files                        2497     2505       +8     
  Lines                       55366    55437      +71     
  Branches                    11448    11467      +19     
==========================================================
+ Hits                        31399    31466      +67     
+ Misses                      21267    21260       -7     
- Partials                     2700     2711      +11     
Flag Coverage Δ
e2e 56.57% <56.19%> (+0.10%) ⬆️
unit 71.89% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris force-pushed the feat/contact-details-tab branch 2 times, most recently from 8d791ac to 8418d41 Compare July 5, 2024 20:42
@dougfabris dougfabris force-pushed the feat/contact-details-tab branch from 4925115 to e296304 Compare July 5, 2024 22:11
@dougfabris dougfabris marked this pull request as ready for review July 8, 2024 15:56
@dougfabris dougfabris requested review from a team as code owners July 8, 2024 15:56
@dougfabris dougfabris requested a review from tassoevan July 10, 2024 18:00
@dougfabris dougfabris merged commit 40c9162 into feat/single-contact-id Jul 10, 2024
48 checks passed
@dougfabris dougfabris deleted the feat/contact-details-tab branch July 10, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants