Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replicate IPreRoomUserLeave and IPostRoomUserLeave event in meteor method and added removedBy to IRoomUserLeaveContext #32724

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Jul 4, 2024

Proposed changes (including videos or screenshots)

Issue(s)

CORE-498
Depends on RocketChat/Rocket.Chat.Apps-engine#779

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Jul 4, 2024

⚠️ No Changeset found

Latest commit: d2730f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Jul 4, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.72%. Comparing base (06707d8) to head (d2730f3).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32724      +/-   ##
===========================================
+ Coverage    56.69%   56.72%   +0.02%     
===========================================
  Files         2495     2498       +3     
  Lines        55352    55403      +51     
  Branches     11448    11460      +12     
===========================================
+ Hits         31382    31425      +43     
- Misses       21267    21271       +4     
- Partials      2703     2707       +4     
Flag Coverage Δ
e2e 56.43% <ø> (+0.01%) ⬆️
e2e-api 41.37% <85.71%> (+0.04%) ⬆️
unit 71.97% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant