-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apps): add user param to update app call #32719
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 1e88e83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32719 +/- ##
===========================================
+ Coverage 51.72% 55.51% +3.78%
===========================================
Files 2346 2634 +288
Lines 52717 57215 +4498
Branches 10871 11849 +978
===========================================
+ Hits 27269 31761 +4492
+ Misses 23068 22760 -308
- Partials 2380 2694 +314
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: Douglas Gubert <[email protected]>
Proposed changes (including videos or screenshots)
Added the
user
param to apps-engine update method call, allowing apps' newonUpdate
hook to know who triggered the update.Issue(s)
Steps to test or reproduce
Further comments
Merge only after: RocketChat/Rocket.Chat.Apps-engine#778