Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: newNavigation Feature preview #32672

Merged
merged 33 commits into from
Jul 10, 2024

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Jun 25, 2024

SIDE-78

Proposed changes (including videos or screenshots)

  • create newNavigation feature preview

  • duplicate ui-client/Header to HeaderV2

  • re-export ui-client/Header in client/components handling feature preview on/off (v1/v2)

  • re-export fuselage/Contextualbar components in client/components handling feature preview on/off (v1/v2)

  • adjust Header imports to point to client/components

  • add client/NavBarV2 files

  • duplicate client/sidebar to client/sidebarv2 with changes

  • apply FeaturePreview toggler for global navbar and search sidebar

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jun 25, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: 876e182

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 18.26981% with 1351 lines in your changes missing coverage. Please review.

Project coverage is 55.58%. Comparing base (6c1d08e) to head (876e182).

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           feat/new-navigation   #32672      +/-   ##
=======================================================
- Coverage                56.68%   55.58%   -1.11%     
=======================================================
  Files                     2501     2626     +125     
  Lines                    55419    57034    +1615     
  Branches                 11465    11853     +388     
=======================================================
+ Hits                     31417    31701     +284     
- Misses                   21290    22624    +1334     
+ Partials                  2712     2709       -3     
Flag Coverage Δ
e2e 54.33% <13.56%> (-2.13%) ⬇️
unit 71.70% <65.03%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti force-pushed the feat/navigation-feature-preview branch 2 times, most recently from 7cd7341 to 72d8151 Compare June 27, 2024 15:41
@juliajforesti juliajforesti marked this pull request as ready for review July 3, 2024 17:28
@juliajforesti juliajforesti requested a review from a team as a code owner July 3, 2024 17:28
@juliajforesti juliajforesti force-pushed the feat/new-navigation branch from 6ed8047 to b183cf4 Compare July 4, 2024 17:09
@juliajforesti juliajforesti force-pushed the feat/navigation-feature-preview branch from bf13b3f to 8aceeaa Compare July 4, 2024 18:29
@juliajforesti juliajforesti force-pushed the feat/new-navigation branch from c1ff3e8 to c2e6e2f Compare July 4, 2024 21:37
@juliajforesti juliajforesti force-pushed the feat/new-navigation branch from c2e6e2f to 6c1d08e Compare July 4, 2024 21:40
@juliajforesti juliajforesti requested a review from tassoevan July 5, 2024 17:43
@juliajforesti juliajforesti force-pushed the feat/navigation-feature-preview branch from 7c2af41 to cb0cc9e Compare July 5, 2024 20:31
@juliajforesti juliajforesti force-pushed the feat/navigation-feature-preview branch from cb0cc9e to 30f7ce8 Compare July 5, 2024 20:58
@juliajforesti juliajforesti requested a review from tassoevan July 8, 2024 21:09
apps/meteor/client/sidebarv2/RoomMenu.tsx Outdated Show resolved Hide resolved
apps/meteor/client/sidebarv2/RoomMenu.tsx Outdated Show resolved Hide resolved
apps/meteor/client/sidebarv2/RoomMenu.tsx Outdated Show resolved Hide resolved
apps/meteor/client/sidebarv2/RoomMenu.tsx Outdated Show resolved Hide resolved
apps/meteor/client/sidebarv2/RoomMenu.tsx Outdated Show resolved Hide resolved
@juliajforesti juliajforesti requested a review from tassoevan July 9, 2024 21:30
@tassoevan tassoevan merged commit 2b33b7d into feat/new-navigation Jul 10, 2024
38 of 40 checks passed
@tassoevan tassoevan deleted the feat/navigation-feature-preview branch July 10, 2024 04:54
@juliajforesti juliajforesti added this to the 6.11 milestone Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants