-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: newNavigation
Feature preview
#32672
feat: newNavigation
Feature preview
#32672
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/new-navigation #32672 +/- ##
=======================================================
- Coverage 56.68% 55.58% -1.11%
=======================================================
Files 2501 2626 +125
Lines 55419 57034 +1615
Branches 11465 11853 +388
=======================================================
+ Hits 31417 31701 +284
- Misses 21290 22624 +1334
+ Partials 2712 2709 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
7cd7341
to
72d8151
Compare
6ed8047
to
b183cf4
Compare
bf13b3f
to
8aceeaa
Compare
c1ff3e8
to
c2e6e2f
Compare
c2e6e2f
to
6c1d08e
Compare
packages/ui-client/src/components/HeaderV2/HeaderTag/HeaderTag.tsx
Outdated
Show resolved
Hide resolved
packages/ui-client/src/components/HeaderV2/HeaderTag/HeaderTagIcon.tsx
Outdated
Show resolved
Hide resolved
packages/ui-client/src/components/HeaderV2/HeaderTag/HeaderTagSkeleton.tsx
Outdated
Show resolved
Hide resolved
packages/ui-client/src/components/HeaderV2/HeaderTitleButton.tsx
Outdated
Show resolved
Hide resolved
7c2af41
to
cb0cc9e
Compare
cb0cc9e
to
30f7ce8
Compare
SIDE-78
Proposed changes (including videos or screenshots)
create
newNavigation
feature previewduplicate
ui-client/Header
toHeaderV2
re-export
ui-client/Header
inclient/components
handling feature preview on/off (v1/v2)re-export
fuselage/Contextualbar
components inclient/components
handling feature preview on/off (v1/v2)adjust
Header
imports to point toclient/components
add
client/NavBarV2
filesduplicate
client/sidebar
toclient/sidebarv2
with changesapply
FeaturePreview
toggler for global navbar and search sidebarIssue(s)
Steps to test or reproduce
Further comments