-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: User roles selection not persisting on editing in users admin panel #32671
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 18d63e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32671 +/- ##
===========================================
- Coverage 56.76% 56.74% -0.03%
===========================================
Files 2496 2496
Lines 55358 55361 +3
Branches 11455 11455
===========================================
- Hits 31423 31412 -11
- Misses 21241 21249 +8
- Partials 2694 2700 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to add some UI tests to ensure the behavior?
Proposed changes (including videos or screenshots)
Currently when we edit user from admin user panel, we don't refetch the user details again on save, due to which the user edit form shows older info, like user roles. So now refetching the user info after saving the user.
Issue(s)
Steps to test or reproduce
Further comments
CORE-39