Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: User roles selection not persisting on editing in users admin panel #32671

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Jun 25, 2024

Proposed changes (including videos or screenshots)

Currently when we edit user from admin user panel, we don't refetch the user details again on save, due to which the user edit form shows older info, like user roles. So now refetching the user info after saving the user.

Issue(s)

Steps to test or reproduce

  1. Log in as an admin user.
  2. Navigate to 'Workspace > Users'.
  3. Click on a user to view their details.
  4. Click on 'Edit'.
  5. In the 'Roles' field, select both 'owner' and 'user'.
  6. Save the changes.
  7. Reopen the edit window for the same user.

Further comments

CORE-39

Copy link
Contributor

dionisio-bot bot commented Jun 25, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 6.11.0, but it targets 6.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 25, 2024

🦋 Changeset detected

Latest commit: 18d63e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.74%. Comparing base (209a062) to head (18d63e0).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32671      +/-   ##
===========================================
- Coverage    56.76%   56.74%   -0.03%     
===========================================
  Files         2496     2496              
  Lines        55358    55361       +3     
  Branches     11455    11455              
===========================================
- Hits         31423    31412      -11     
- Misses       21241    21249       +8     
- Partials      2694     2700       +6     
Flag Coverage Δ
e2e 56.49% <60.00%> (-0.03%) ⬇️
unit 71.88% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal yash-rajpal marked this pull request as ready for review June 25, 2024 22:24
@yash-rajpal yash-rajpal requested a review from a team as a code owner June 25, 2024 22:24
@yash-rajpal yash-rajpal added this to the 6.11 milestone Jun 26, 2024
Copy link
Contributor

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add some UI tests to ensure the behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants