Skip to content

Conversation

@debdutdeb
Copy link
Member

@debdutdeb debdutdeb commented Jun 12, 2024

https://rocketchat.atlassian.net/browse/CORE-497

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

with the removal of most meteor methods, I don't see any particular reason to keep this setting around. This is a must for ms deployments anyway, no harm is just making it the only reality.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 12, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 12, 2024

🦋 Changeset detected

Latest commit: a77d15d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch
@rocket.chat/omni-core-ee Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@debdutdeb debdutdeb force-pushed the remove-realtime-call-setting branch from a0d097a to 15abdf1 Compare June 12, 2024 09:41
@codecov
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.80%. Comparing base (4b0c913) to head (a77d15d).
⚠️ Report is 1 commits behind head on release-8.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-8.0.0   #32590   +/-   ##
==============================================
  Coverage          65.80%   65.80%           
==============================================
  Files               3186     3186           
  Lines             106629   106627    -2     
  Branches           20323    20324    +1     
==============================================
+ Hits               70162    70170    +8     
+ Misses             33798    33787   -11     
- Partials            2669     2670    +1     
Flag Coverage Δ
e2e 58.04% <100.00%> (+0.02%) ⬆️
unit 71.08% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we need to fix the lint problems: cd apps/meteor && yarn eslint:fix

@ggazzo ggazzo force-pushed the release-7.0.0 branch 3 times, most recently from bc4fad7 to b484993 Compare June 24, 2024 11:48
@ggazzo ggazzo force-pushed the release-7.0.0 branch 2 times, most recently from b285fd4 to 39a6fe1 Compare July 16, 2024 15:10
@ggazzo ggazzo force-pushed the release-7.0.0 branch 4 times, most recently from ce44882 to d94b784 Compare July 29, 2024 19:47
@ggazzo ggazzo force-pushed the release-7.0.0 branch 2 times, most recently from 30f6f98 to 8c447cf Compare August 16, 2024 13:09
@ggazzo ggazzo force-pushed the release-7.0.0 branch 4 times, most recently from c6874ac to fff2293 Compare September 11, 2024 22:14
@ggazzo ggazzo force-pushed the release-7.0.0 branch 4 times, most recently from 9ba3bd2 to fcd8105 Compare September 16, 2024 01:13
@ggazzo ggazzo force-pushed the release-7.0.0 branch 4 times, most recently from 50abbe6 to bf02ce5 Compare September 27, 2024 22:43
ggazzo added a commit that referenced this pull request Oct 31, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 31, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
yash-rajpal pushed a commit that referenced this pull request Nov 4, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Nov 4, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Nov 5, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Nov 5, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Nov 5, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Nov 6, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Nov 12, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Nov 12, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Nov 13, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Nov 18, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 2, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 9, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 10, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 15, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 17, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 17, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 18, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 18, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 18, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 19, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 19, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 19, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 20, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 20, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 20, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
dougfabris pushed a commit that referenced this pull request Dec 20, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants