-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: Fixed image gallery not working on Electron app #32578
Conversation
…allery compatibility
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32578 +/- ##
===========================================
+ Coverage 56.37% 56.41% +0.04%
===========================================
Files 2437 2436 -1
Lines 53773 53742 -31
Branches 11082 11076 -6
===========================================
+ Hits 30313 30318 +5
+ Misses 20810 20776 -34
+ Partials 2650 2648 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Since this issue can only be reproduced in older chromium versions, there's no way to add new end-to-end tests specifically for this (we'd need to downgrade playwright in order to do that). |
Proposed changes (including videos or screenshots)
toReversed
js function (not supported in older "browers" such as in the Electron app)Issue(s)
CORE-490
Steps to test or reproduce
Further comments
Introduced by #32106